On Sun 2006-10-01 18:22:28, Heikki Orsila wrote:
> Some nitpicking about the patch follows..
>
> On Sat, Sep 30, 2006 at 02:24:35AM +0400, Eugeny S. Mints wrote:
> > +static long
> > +get_vtg(const char *vdomain)
> > +{
> > + long ret = 0;
>
> Unnecessary initialisation.
No, sorry.
> > +static long
> > +set_vtg(const char *vdomain, int val)
> > +{
> > + long ret = 0;
>
> here too. This and 'int i = 0;' happens in many functions.
Wrong again. automatic variables are not zero initialized.
> > + err = omap_pm_core_verify_opt(opt);
> > + if (err != 0)
> > + goto out;
> > +
> > + return (void *)opt;
> > +out:
> > + kfree(opt);
> > + return NULL;
> > +}
>
> Maybe use if (err != 0) { kfree(opt); return NULL; } because goto out is
> only used once?
This is actually common kernel idiom, so it is okay to leave like
this. Your other points are ok.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
