On Wed, Sep 27, 2006 at 03:47:31PM +0100, Matthew Garrett wrote:
> On Wed, Sep 27, 2006 at 12:20:29AM -0400, Dave Jones wrote:
>
> > Good question. There's no real replacement for pm_active in the non-legacy
> > config afaik. Perhaps the cleanest alternative is to undeprecate that macro?
> > The only other option I can think of is doing something like this in apm.c ...
> >
> > +#ifdef CONFIG_ACPI
> > - if (PM_IS_ACTIVE()) {
> > printk(KERN_NOTICE "apm: overridden by ACPI.\n");
> > apm_info.disabled = 1;
> > return -ENODEV;
> > - }
> > +#endif
>
> That's not a good choice - it needs to be a runtime check, not a
> compile-time one. Don't we have an acpi_enabled() function?
You're right, the above would break if booted with acpi=off.
Hmm.
Dave
