Hi! > > > So you say. Have you actually ever done anything to make debugging easier? > > > > I've implemented suspend/resume for a whole range of machiens where > > everything goes down and all I have to debug on resume is ... sending > > commands to a chip to blink a LED. So yes, I have. > > That's not what I asked. > > I didn't ask whether you had debugged suspend/resume. > > I asked whether you had tried to make it easier. > > > None of the problems I've had were ever related to something that would > > be in save_state. > > Ok, I've had very different things happen. > > Here's a _fact_: > > - we currently walk the device chain to suspend different devices > - one device returns an error > - we've now suspended half the machine, done major things, and we need to > undo it > - the thing fails. You are right, suspend error handling sucks... > Are you seriously claiming this has never happened to you? It sure has > happened to me. > > And YES, THIS WOULD BE IMPROVED BY MY SCHEME. Instead of getting a > machine ...unfortunately your proposal makes non-errors paths to suck, too. Now, if we really wanted to do something about this... we could just resume the console, then print a message and panic(). If our error handling never ever works, this at least has chance to show that message. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
