On Thu, 22 Jun 2006, Benjamin Herrenschmidt wrote: > > I never said your thing was introducing those problems, we are > misunderstanding each other there. I want that prepare() thing and > wanted it for some time now to fix an existing problem :) I still > disagree with the save_state/suspend split for the reason I exposed > later in the email. You can use save_state() for your "prepare()" if you want to, but I don't see what you are disagreeing or arguing about then. > With a split save_state/suspend, you can end up with the scenario where > > 1- save state saves the device "state", that includes the keys in the > controller > 2- client above calls you to change the keys > 3- suspend > 4- restore_state > > At that point, what keys are you restoring ? You don't _do_ that, Ben. If you did that, you'd get the old keys. Your complaint is like "Doctor, doctor, it hurts when I dig out my eyes with a dull spool" OF COURSE it hurts. Don't do it. Your example is insane. Linus
