On Wed, Feb 08, 2006 at 05:08:58PM +0000, Matthew Garrett wrote: > On Wed, Feb 08, 2006 at 08:58:03AM -0800, Greg KH wrote: > > > +{ > > > + down(&pm_sem); > > > > Shouldn't this be a mutex? > > It is, isn't it? The name's somewhat misleading, but I was just using > what already existed... Ah, ok, nevermind, I thought this was new. > +/** > + * pm_set_ac_status - Set the ac status callback. Returns true if the > + * system is on AC and has a registered callback. kerneldoc will not work with this. It needs to be a one line, short, description. Put the full description below the function paramaters, it can be as many lines as you want there. thanks, greg k-h