On Wed, Feb 08, 2006 at 01:04:22PM +0000, Matthew Garrett wrote:
> +/**
> + * pm_set_ac_status - Set the ac status callback
> + * @ops: Pointer to function
> + */
> +
> +void pm_set_ac_status(int (*ac_status_function)(void))
No extra line in there please.
And perhaps a bit more description of what this is used for?
> +{
> + down(&pm_sem);
Shouldn't this be a mutex?
> + get_ac_status = ac_status_function;
> + up(&pm_sem);
> +}
> +
> +EXPORT_SYMBOL(pm_set_ac_status);
No extra line between the function and the EXPORT_SYMBOL please.
Also, how about EXPORT_SYMBOL_GPL()?
And, who will be using this interface, and what for?
> +
> +/**
> + * pm_get_ac_status - return true if the system is on AC
> + */
> +
> +int pm_get_ac_status(void)
> +{
> + int status;
> +
> + down (&pm_sem);
> + if (get_ac_status)
> + status = get_ac_status();
> + else
> + status = 0;
> + up (&pm_sem);
You can save 2 lines by setting status = 0 on the first line of this
function :)
thanks,
greg k-h
