One more nit... > + s += sprintf(s, "d0"); > + if (dev->poss_states[PCI_D1]) > + s += sprintf(s, " d1"); > + if (dev->poss_states[PCI_D2]) > + s += sprintf(s, " d2"); > + if (dev->poss_states[PCI_D3hot]) > + s += sprintf(s, " d3"); ... > --- a/include/linux/pci.h > +++ b/include/linux/pci.h > @@ -106,6 +106,7 @@ struct pci_dev { > this if your device has broken DMA > or supports 64-bit transfers. */ > > + u32 poss_states[4]; So this probably should be poss_states[PCI_D3hot]; or something, instead of explicit "4". Pavel -- Thanks, Sharp!