Hi, On Tuesday, 29 of March 2005 23:12, Pavel Machek wrote: > Hi! > > > > I don't really want us to try execve during resume... Could we simply > > > artifically fail that execve with something if (in_suspend()) return > > > -EINVAL; [except that in_suspend() just is not there, but there were > > > some proposals to add it]. > > > > > > Or just avoid calling hotplug at all in resume case? And then do > > > coldplug-like scan when userspace is ready... > > > > > > > I am leaning towards calling disable_usermodehelper (not writtent yet) > > after swsusp completes snapshotting memory. We really don't care about > > hotplug events in this case and this will allow keeping "normal" > > resume in drivers as is. What do you think? > > That would certianly do the trick. > > [Or perhaps in_suspend() is slightly nicer solution? People wanted it > for other stuff (sanity checking, like BUG_ON(in_suspend())), too....] IMHO, they are not mutually exclusive. However, by using disable_usermodehelper we would get rid of the reason (ie hotplug events) instead of just curing the symptoms (ie execve() during suspend). Greets, Rafael -- - Would you tell me, please, which way I ought to go from here? - That depends a good deal on where you want to get to. -- Lewis Carroll "Alice's Adventures in Wonderland"
