On Wed, 23 Mar 2005, Pavel Machek wrote:
A couple of questions:
> --- clean/drivers/base/power/shutdown.c 2004-08-15 19:14:55.000000000 +0200
> +++ linux/drivers/base/power/shutdown.c 2005-03-22 12:20:53.000000000 +0100
> @@ -29,7 +29,8 @@
> dev->driver->shutdown(dev);
> return 0;
> }
> - return dpm_runtime_suspend(dev, dev->detach_state);
> + /* FIXME */
> + return dpm_runtime_suspend(dev, PMSG_FREEZE);
Why is this a FIXME? Mind adding a bit more descriptive of a comment
there?
> --- clean/drivers/base/power/sysfs.c 2004-08-15 19:14:55.000000000 +0200
> +++ linux/drivers/base/power/sysfs.c 2005-03-22 12:20:53.000000000 +0100
> @@ -26,19 +26,20 @@
>
> static ssize_t state_show(struct device * dev, char * buf)
> {
> - return sprintf(buf, "%u\n", dev->power.power_state);
> + return sprintf(buf, "%u\n", dev->power.power_state.event);
> }
>
> static ssize_t state_store(struct device * dev, const char * buf, size_t n)
> {
> - u32 state;
> + pm_message_t state;
> char * rest;
> int error = 0;
>
> - state = simple_strtoul(buf, &rest, 10);
> + state.event = simple_strtoul(buf, &rest, 10);
> +// state.flags = PFL_RUNTIME;
What is PFL_RUNTIME?
This appears to be the only usage of the .flags field. Perhaps we should
omit that field (and this commented out line) for now?
Thanks,
Pat
