swsusp & modules [was Re: [linux-pm] [Fwd: Re: PM messages]]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

> I have no preference at this point, I see either a struct made of an
> enum plus some flags (FREEZE/IDLE/SUSPEND/RESUME enum, plus some flags
> indicating what phase of STD we are, or that we are doing STR, or
> some other stuff we may want to define). Or a single enum with more
> varied messages (like RESUME_FROM_STR, RESUME_FROM_STD,
> RESUME_FROM_STD_SNAPSHOT_FREEZE, ... :)

I believe enum plus flags is better idea.. In case we'll need to
introduce new levels in future, doing it with "big enum" would be
painfull.

> There may be other ways. But keep in mind that most drivers will not
> care, that is they will do just the same thing on all resume cases,
> so if we define too many enums, we'll end up with 3 or 4 cases in
> drivers and drivers missing one, etc... that sort of horror. I like
> the main + flags idea because drivers will usually just have a single
> case _and_ we can add more flags in the future for other sutble
> distinction we want to make without breaking all drivers.

Agreed.
								Pavel
-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!


[Index of Archives]     [Linux ACPI]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [CPU Freq]     [Kernel Newbies]     [Fedora Kernel]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux