Hi! > > > Or we could always pass full state and have helpers that tell "easy" > > > version (i.e. PM_FREEZE) to simple drivers. Hopefully no drivers will > > > ever use full information but we want it there. > > > > I'm open to both solutions here. David, what do you prefer ? Patrick ? > > We need better vocabulary. In previous messages, you mixed 'freeze' and > 'suspend'; and 'unfreeze' and 'resume'. Each one of those has differently > defined semantics in other contexts. > > I assume that the idea is still to have multiple calls to perform the > entire transition - the first being to queisce the driver and stop any > activity; the second being to perform the actual power transition. > (Actually, there should be three - an additional one in the middle to save > the device states.) > > Do we agree on that? No. Two transitions were okay up-to now, and I see no reason why to introduce 3rd. And btw, during suspend-to-disk it is "freeze, unfreeze, suspend". > - Stop > - Start Would be confusing to network drivers (they use stop/start already for something else). And besides it is very bad idea to try to change naming once again. Pavel -- 64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
