Re: [PATCH] PCI/portdrv: Don't disable pci device during shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/21/2020 10:11 PM, Huacai Chen wrote:
>> his sounds like a quirk to me rather than a behavior that should be
>> applied to all platforms.
> Yes, this is very like a quirk, but it seems there are a lot of
> platforms that have problems, and removing the pci_disable_device()
> has no side effect.

Why is there no side effect?

AFAIK, kexec goes through the shutdown path and you are leaving a PCI
device enabled during kexec boot which can corrupt the booting OS
memory.

I don't think you can generalize a behavior based on a few quirky
devices. You should be quirking only the device that has a problem
rather than changing the behavior of all other platforms.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux