Hi, Sinan,
On Mon, Sep 21, 2020 at 11:50 PM Sinan Kaya <okaya@xxxxxxxxxx> wrote:
>
> On 9/21/2020 5:22 AM, Huacai Chen wrote:
> > Use separate remove()/shutdown() callback, and don't disable pci device
> > during shutdown. This can avoid some poweroff/reboot failures.
> >
> > The poweroff/reboot failures can easily reproduce on Loongson platforms.
> > I think this is not a Loongson-specific problem, instead, is a problem
> > related to some specific PCI hosts. On some x86 platforms, radeon/amdgpu
> > devices can cause the same problem, and commit faefba95c9e8ca3a523831c2e
> > ("drm/amdgpu: just suspend the hw on pci shutdown") can resolve it.
>
> This sounds like a quirk to me rather than a behavior that should be
> applied to all platforms.
Yes, this is very like a quirk, but it seems there are a lot of
platforms that have problems, and removing the pci_disable_device()
has no side effect.
Huacai
