From: Bolarinwa Olayemi Saheed <refactormyself@xxxxxxxxx> PATCH 1 to 7: PCIBIOS_ error codes have positive values and they are passed down the call heirarchy from accessors. For functions which are meant to return only a negative value on failure, passing on this value is a bug. To mitigate this, call pcibios_err_to_errno() before passing on return value from pcie capability accessors call heirarchy. This function converts any positive PCIBIOS_ error codes to negative non-PCI generic error values. PATCH 8: The pcie capability accessors can return 0, -EINVAL, or any PCIBIOS_ error code. The pci accessor on the other hand can only return 0 or any PCIBIOS_ error code.This inconsistency among these accessor makes it harder for callers to check for errors. Return PCIBIOS_BAD_REGISTER_NUMBER instead of -EINVAL in all pcie capability accessors. Bolarinwa Olayemi Saheed (8): PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes PCI: Convert PCIBIOS_ error codes to non-PCI generic error codes PCI: Align return value of pcie capability accessors with other accessors drivers/dma/ioat/init.c | 4 ++-- drivers/infiniband/hw/hfi1/pcie.c | 18 +++++++++++++----- drivers/pci/access.c | 8 ++++---- drivers/pci/pci.c | 10 ++++++++-- drivers/pci/pcie/aer.c | 12 ++++++++++-- drivers/scsi/smartpqi/smartpqi_init.c | 6 +++++- 6 files changed, 42 insertions(+), 16 deletions(-) -- 2.18.2