On 2020-06-09 9:51 a.m., Christoph Hellwig wrote: > On Tue, Jun 09, 2020 at 11:16:46AM +0200, Piotr Stankiewicz wrote: >> Seeing as there is shorthand available to use when asking for any type >> of interrupt, or any type of message signalled interrupt, leverage it. >> >> Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@xxxxxxxxx> >> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> >> Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx> > > The patch actually adding PCI_IRQ_MSI_TYPES still didn't show up on > linux-pci. > > But from the person who added PCI_IRQ_*: > > NAK to the whole concept of PCI_IRQ_MSI_TYPES, I think this just makes > the code a lot more confusing. Especially with the new IMS interrupt > type, which really is a MSI-like interrupt but certainly shouldn't be > added to this mask. Yes, after cleaning up the first patch to not require the long messy conditional, this change doesn't seems like a win. I agree we should drop these patches. Logan
