On Thu, May 07, 2020 at 09:34:35PM +0200, ansuelsmth@xxxxxxxxx wrote: > > On Fri, May 01, 2020 at 12:06:15AM +0200, Ansuel Smith wrote: > > > It is now supported the editing of Tx De-Emphasis, Tx Swing and > > > Rx equalization params on ipq8064. Document this new optional params. > > > > > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > > > --- > > > .../devicetree/bindings/pci/qcom,pcie.txt | 36 +++++++++++++++++++ > > > 1 file changed, 36 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt > > b/Documentation/devicetree/bindings/pci/qcom,pcie.txt > > > index 6efcef040741..8cc5aea8a1da 100644 > > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt > > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt > > > @@ -254,6 +254,42 @@ > > > - "perst-gpios" PCIe endpoint reset signal line > > > - "wake-gpios" PCIe endpoint wake signal line > > > > > > +- qcom,tx-deemph-gen1: > > > + Usage: optional (available for ipq/apq8064) > > > + Value type: <u32> > > > + Definition: Gen1 De-emphasis value. > > > + For ipq806x should be set to 24. > > > > Unless these need to be tuned per board, then the compatible string for > > ipq806x should imply all these settings. > > > > It was requested by v2 to make this settings tunable. These don't change are > all the same for every ipq806x SoC. The original implementation had this > value hardcoded for ipq806x. Should I restore this and drop this patch? Yes, please. Rob
