On Sat, May 2, 2020 at 12:41 AM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > All callers of platform_get_irq() and related functions interpret a > negative return value as an error. A few also interpret zero as an error. > > platform_get_irq() should return either a negative error number or a valid > non-zero IRQ, so there's no need to check for zero. > > This series: > > - Extends the platform_get_irq() function comment to say it returns a > non-zero IRQ number or a negative error number. > > - Adds a WARN() if platform_get_irq() ever *does* return zero (this would > be a bug in the underlying arch code, and most callers are not prepared > for this). > > - Updates drivers/pci/ to check consistently using "irq < 0". > > This is based on Aman's series [1]. I propose to merge this via the PCI > tree, given acks from Greg and Thomas. > > [1] https://lore.kernel.org/r/cover.1583952275.git.amanharitsh123@xxxxxxxxx Makes sense to me. Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> for the series. Yours, Linus Walleij
