Re: [PATCH 1/3] ACPI / utils: Add acpi_evaluate_reg() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 5/5/20 5:42 PM, Andy Shevchenko wrote:
On Tue, May 05, 2020 at 03:21:26PM +0200, Hans de Goede wrote:
With a recent fix to the pinctrl-cherryview driver we know have
2 drivers open-coding the parameter building / passing for calling
_REG on an ACPI handle.

Add a helper for this, so that these 2 drivers can be converted to this
helper.

Suggested-by?

Right sorry about that I will fix this for v2.

>> + * @function: Parameter to pass to _REG one of ACPI_REG_CONNECT or
>> + *            ACPI_REG_DISCONNECT
>
> Is it enum or definitions? If former can we refer to it?

These are #define-s.

Regards,

Hans




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux