On Tue, May 05, 2020 at 03:21:26PM +0200, Hans de Goede wrote: > With a recent fix to the pinctrl-cherryview driver we know have > 2 drivers open-coding the parameter building / passing for calling > _REG on an ACPI handle. > > Add a helper for this, so that these 2 drivers can be converted to this > helper. > + * @function: Parameter to pass to _REG one of ACPI_REG_CONNECT or > + * ACPI_REG_DISCONNECT Is it enum or definitions? If former can we refer to it? (Sorry, clicked reply to fast with previous mail) -- With Best Regards, Andy Shevchenko