Hi Shimoda-san, Thank you for the review. > -----Original Message----- > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > Sent: 03 April 2020 09:28 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; Rob Herring > <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; Geert Uytterhoeven <geert+renesas@xxxxxxxxx>; Magnus Damm > <magnus.damm@xxxxxxxxx>; Kishon Vijay Abraham I <kishon@xxxxxx>; Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>; Marek Vasut > <marek.vasut+renesas@xxxxxxxxx>; linux-pci@xxxxxxxxxxxxxxx > Cc: Catalin Marinas <catalin.marinas@xxxxxxx>; Will Deacon <will@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx>; Andrew Murray <andrew.murray@xxxxxxx>; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-renesas-soc@xxxxxxxxxxxxxxx; Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>; Frank Rowand > <frowand.list@xxxxxxxxx>; Gustavo Pimentel <gustavo.pimentel@xxxxxxxxxxxx>; Jingoo Han <jingoohan1@xxxxxxxxx>; Simon Horman > <horms@xxxxxxxxxxxx>; Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>; Tom Joseph <tjoseph@xxxxxxxxxxx>; Heiko Stuebner > <heiko@xxxxxxxxx>; linux-rockchip@xxxxxxxxxxxxxxxxxxx; Lad Prabhakar <prabhakar.csengg@xxxxxxxxx>; Prabhakar Mahadev Lad > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > Subject: RE: [PATCH v6 07/11] dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint controller > > Hi Prabhakar-san, > > Thank you for your patch! > > > From: Lad Prabhakar, Sent: Friday, April 3, 2020 4:39 AM > <snip> > > diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml > > b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml > > new file mode 100644 > > index 000000000000..07cd5a7325d0 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > I'm sorry I should have mentioned in the previous review. > This is better like the following. > > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > https://patchwork.kernel.org/patch/11459267/#23246825 > Argh my bad I should have noticed this too, usual tendency is to ignore the patch when its being Acked 😃 > <snip> > > +examples: > > + - | > > + #include <dt-bindings/clock/r8a774c0-cpg-mssr.h> > > + #include <dt-bindings/power/r8a774c0-sysc.h> > > + > > + pcie0_ep: pcie-ep@fe000000 { > > + compatible = "renesas,r8a774c0-pcie-ep", > > + "renesas,rcar-gen3-pcie-ep"; > > + reg = <0 0xfe000000 0 0x80000>, > > + <0x0 0xfe100000 0 0x100000>, > > + <0x0 0xfe200000 0 0x200000>, > > + <0x0 0x30000000 0 0x8000000>, > > + <0x0 0x38000000 0 0x8000000>; > > Examples are built with #{address,size}-cells = <1>, so > > reg = <0xfe000000 0x80000>, > <0xfe100000 0x100000>, > <0xfe200000 0x200000>, > <0x30000000 0x8000000>, > <0x38000000 0x8000000>; > > https://patchwork.kernel.org/patch/11459267/#23246825 > Will change this as above. Cheers, --Prabhakar > Best regards, > Yoshihiro Shimoda Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
