Bjorn,
Bjorn Helgaas <helgaas@xxxxxxxxxx> writes:
> On Fri, Mar 13, 2020 at 04:56:42PM -0500, Bjorn Helgaas wrote:
>> On Fri, Mar 13, 2020 at 10:05:58PM +0100, Thomas Gleixner wrote:
>> > > I think the best pattern is:
>> > >
>> > > irq = platform_get_irq(pdev, i);
>> > > if (irq < 0)
>> > > return irq;
>> >
>> > Careful. 0 is not a valid interrupt.
>>
>> Should callers of platform_get_irq() check for a 0 return value?
>> About 900 of them do not.
I don't know what I was looking at.
platform_get_irq() does the right thing already, so checking for irq < 0
is sufficient.
Sorry for the confusion!
Thanks,
tglx
