On Wed, 2020-02-19 at 11:13 -0800, Florian Fainelli wrote: > On 2/19/20 4:39 AM, Nicolas Saenz Julienne wrote: > > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be > > loaded directly from an EEPROM or, if not present, by the SoC's > > VideCore. The function informs VideCore that VL805 was just reset, or > > requests for a probe defer. > > > > Based on Tim Gover's downstream implementation. > > > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@xxxxxxx> > > --- > > [snip] > > > > diff --git a/include/soc/bcm2835/raspberrypi-firmware.h > > b/include/soc/bcm2835/raspberrypi-firmware.h > > index cc9cdbc66403..a37c3a461d2a 100644 > > --- a/include/soc/bcm2835/raspberrypi-firmware.h > > +++ b/include/soc/bcm2835/raspberrypi-firmware.h > > @@ -8,6 +8,7 @@ > > > > #include <linux/types.h> > > #include <linux/of_device.h> > > +#include <linux/pci.h> > > I would move this inclusion where we need it, which is in > drivers/firmware/raspberrypi.c and only provide a forward declaration > here (avoids needless rebuilds). Noted
Attachment:
signature.asc
Description: This is a digitally signed message part