Thanks Keith, On Tue, 2020-01-07 at 12:13 -0700, Keith Busch wrote: > On Mon, Jan 06, 2020 at 03:41:22PM -0700, Sushma Kalakota wrote: > > This patch adds support for this VMD device which supports the bus > > restriction mode. > > Suggested rephrasing to an imperative voice: > > Add new VMD device IDs that require the bus restriction mode. > Sure > > Signed-off-by: Jon Derrick <jonathan.derrick@xxxxxxxxx> > > Signed-off-by: Sushma Kalakota <sushmax.kalakota@xxxxxxxxx> > > The first sign-off should be the author, but there's no "From:" header > line for Jon. Is the attribution correct? We both worked on this, though it was primarily Sushma. We'll switch the attribution order per https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin > > > @@ -868,6 +868,8 @@ static const struct pci_device_id vmd_ids[] = { > > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0), > > .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW | > > VMD_FEAT_HAS_BUS_RESTRICTIONS,}, > > + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_467F), > > + .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,}, > > {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_4C3D), > > .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,}, > > Since you know all the new device ids, might as well collapse this patch > with the first one from this series. Sure
