On Mon, Jan 06, 2020 at 03:41:22PM -0700, Sushma Kalakota wrote:
> This patch adds support for this VMD device which supports the bus
> restriction mode.
Suggested rephrasing to an imperative voice:
Add new VMD device IDs that require the bus restriction mode.
> Signed-off-by: Jon Derrick <jonathan.derrick@xxxxxxxxx>
> Signed-off-by: Sushma Kalakota <sushmax.kalakota@xxxxxxxxx>
The first sign-off should be the author, but there's no "From:" header
line for Jon. Is the attribution correct?
> @@ -868,6 +868,8 @@ static const struct pci_device_id vmd_ids[] = {
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_28C0),
> .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW |
> VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> + {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_467F),
> + .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
> {PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_VMD_4C3D),
> .driver_data = VMD_FEAT_HAS_BUS_RESTRICTIONS,},
Since you know all the new device ids, might as well collapse this patch
with the first one from this series.
