Hi Eric, On Tue, Dec 17, 2019 at 12:05:18PM +0100, Auger Eric wrote: > > + fwspec = dev_iommu_fwspec_get(dev); > > + if (!err && fwspec) > > + of_property_read_u32(master_np, "pasid-num-bits", > > + &fwspec->num_pasid_bits); > > + } > This patch dedicates to platform devices however I fail to understand, > at that stage, how/when do you retrieve/store the same max capability > for PCI devices? For PCI devices, the max capability is only described by the PCIe PASID capability, not by firmware. Patch 13 deals with PCI by setting masted->ssid_bits from the PASID capability directly, ignoring fwspec->num_pasid_bits. > Besides, > > Reviewed-by: Eric Auger <eric.auger@xxxxxxxxxx> Thanks! Jean
