On Thu, Oct 17, 2019 at 12:25:19AM -0700, Christoph Hellwig wrote: > On Wed, Oct 16, 2019 at 03:06:23PM -0500, Rob Herring wrote: > > +static inline struct resource_entry *resource_list_get_entry_of_type(struct list_head *list, > > + unsigned long type) > > This adds a way too long line. > > Part of that is that the name just seems way too long as well, any > good shorter name? resourse_list_first_type? I think it's really helpful to use the word 'first' in there somewhere, it makes it a little clearer on what happens if there are multiple of the same type of resource. Thanks, Andrew Murray