Re: [PATCH V5 2/3] PCI: dwc: Cleanup DBI read and write APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/21/2019 2:57 PM, Kishon Vijay Abraham I wrote:
Hi Vidya,

On 21/06/19 2:51 PM, Vidya Sagar wrote:
Cleanup DBI read and write APIs by removing "__" (underscore) from their
names as there are no no-underscore versions and the underscore versions
are already doing what no-underscore versions typically do.

Signed-off-by: Vidya Sagar <vidyas@xxxxxxxxxx>
---
Changes from v4:
* This is a new patch in this series

  drivers/pci/controller/dwc/pcie-designware.c | 16 ++++-----
  drivers/pci/controller/dwc/pcie-designware.h | 36 ++++++++++----------
  2 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
index 9d7c51c32b3b..5d22028d854e 100644
--- a/drivers/pci/controller/dwc/pcie-designware.c
+++ b/drivers/pci/controller/dwc/pcie-designware.c
@@ -52,8 +52,8 @@ int dw_pcie_write(void __iomem *addr, int size, u32 val)
  	return PCIBIOS_SUCCESSFUL;
  }
-u32 __dw_pcie_read_dbi(struct dw_pcie *pci, void __iomem *base, u32 reg,
-		       size_t size)
+u32 dw_pcie_read_dbi(struct dw_pcie *pci, void __iomem *base, u32 reg,
+		     size_t size)

The "base" here was added when we used the same API for both dbi_base and
dbi_base2. Now that we have separate APIs, we should be able to remove that.

Thanks
Kishon

Got it. Let me address it.




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux