On 2019-06-19 8:01 a.m., Nicholas Johnson wrote: > Hi Ben and Logan, > > It looks like my git send-email has been not working correctly since I > started trying to get these patches accepted. I may have remedied this > now, but I have seen that Logan tried to find these patches and failed. > So as a courtesy until I post PATCH v7 (hopefully correctly, this time), > I am forwarding you the patches. I hope you like them. I would love to > know of any concerns or questions you may have, and / or what happens if > you test them. Thanks and all the best! > > ----- Forwarded message from Nicholas Johnson <nicholas.johnson-opensource@xxxxxxxxxxxxxx> ----- > > Date: Thu, 23 May 2019 06:29:28 +0800 > From: Nicholas Johnson <nicholas.johnson-opensource@xxxxxxxxxxxxxx> > To: linux-kernel@xxxxxxxxxxxxxxx > Cc: linux-pci@xxxxxxxxxxxxxxx, bhelgaas@xxxxxxxxxx, mika.westerberg@xxxxxxxxxxxxxxx, corbet@xxxxxxx, Nicholas Johnson <nicholas.johnson-opensource@xxxxxxxxxxxxxx> > Subject: [PATCH v6 4/4] PCI: Add pci=hpmemprefsize parameter to set MMIO_PREF size independently > X-Mailer: git-send-email 2.19.1 > > Add kernel parameter pci=hpmemprefsize=nn[KMG] to control MMIO_PREF size > for PCI hotplug bridges. Makes sense. > Change behaviour of pci=hpmemsize=nn[KMG] to not set MMIO_PREF size if > hpmempref has been specified, rather than controlling both MMIO and > MMIO_PREF sizes unconditionally. I don't think I like that fact that hpmemsize behaves differently if hpmempref size is specfied before it. I'd probably suggest having three parameters: hpmemsize which sets both as it always has, a pref one and a regular one which each set one of parameters. Logan
