On Fri, Jan 11, 2019 at 11:53 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Fri, Jan 04, 2019 at 08:53:35AM -0800, Andrey Smirnov wrote: > > Add code needed to support i.MX8MQ variant. > > > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > Cc: Fabio Estevam <fabio.estevam@xxxxxxx> > > Cc: Chris Healy <cphealy@xxxxxxxxx> > > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > > Cc: Leonard Crestez <leonard.crestez@xxxxxxx> > > Cc: "A.s. Dong" <aisheng.dong@xxxxxxx> > > Cc: Richard Zhu <hongxing.zhu@xxxxxxx> > > Cc: Rob Herring <robh@xxxxxxxxxx>, > > Cc: devicetree@xxxxxxxxxxxxxxx, > > Cc: linux-imx@xxxxxxx > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > Cc: linux-kernel@xxxxxxxxxxxxxxx > > Cc: linux-pci@xxxxxxxxxxxxxxx > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > > --- > > .../bindings/pci/fsl,imx6q-pcie.txt | 3 +- > > drivers/pci/controller/dwc/Kconfig | 4 +- > > drivers/pci/controller/dwc/pci-imx6.c | 77 ++++++++++++++++++- > > 3 files changed, 79 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > > index d514c1f2365f..920ca93870a8 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > > @@ -9,6 +9,7 @@ Required properties: > > - "fsl,imx6sx-pcie", > > - "fsl,imx6qp-pcie" > > - "fsl,imx7d-pcie" > > + - "fsl,imx8mq-pcie" > > - reg: base address and length of the PCIe controller > > - interrupts: A list of interrupt outputs of the controller. Must contain an > > entry for each entry in the interrupt-names property. > > @@ -45,7 +46,7 @@ Additional required properties for imx6sx-pcie: > > PCIE_PHY power domains > > - power-domain-names: Must be "pcie", "pcie_phy" > > > > -Additional required properties for imx7d-pcie: > > +Additional required properties for imx7d-pcie and imx8mq-pcie: > > - power-domains: Must be set to a phandle pointing to PCIE_PHY power domain > > - resets: Must contain phandles to PCIe-related reset lines exposed by SRC > > IP block > > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig > > index 6aafec3fad00..83ea318ad989 100644 > > --- a/drivers/pci/controller/dwc/Kconfig > > +++ b/drivers/pci/controller/dwc/Kconfig > > @@ -89,8 +89,8 @@ config PCI_EXYNOS > > select PCIE_DW_HOST > > > > config PCI_IMX6 > > - bool "Freescale i.MX6/7 PCIe controller" > > - depends on SOC_IMX6Q || SOC_IMX7D || (ARM && COMPILE_TEST) > > + bool "Freescale i.MX6/7/8 PCIe controller" > > + depends on SOC_IMX6Q || SOC_IMX7D || (ARM64 && ARCH_MXC) || ((ARM || ARM64) && COMPILE_TEST) > > Since you added the ifdef around the abort handler, I think you can drop > "(ARM || ARM64)" and enable building other arches. > OK, makes sense. I'll give it a go in v5. Thanks, Andrey Smirnov