On Tue, Dec 18, 2018 at 1:34 AM Leonard Crestez <leonard.crestez@xxxxxxx> wrote:
>
> On Mon, 2018-12-17 at 20:07 -0800, Andrey Smirnov wrote:
> > Add code needed to support i.MX8MQ variant.
>
> > static void imx6_pcie_init_phy(struct imx6_pcie *imx6_pcie)
> > {
> > +
> > +
> Remove empty lines?
>
Sure, will do.
> > + unsigned int mask, val, offset;
> > +
> > + mask = IMX6Q_GPR12_DEVICE_TYPE;
> > + val = FIELD_PREP(IMX6Q_GPR12_DEVICE_TYPE, PCI_EXP_TYPE_ROOT_PORT);
>
> ... snip ...
>
> > - regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12,
> > - IMX6Q_GPR12_DEVICE_TYPE, PCI_EXP_TYPE_ROOT_PORT << 12);
> > + regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, mask, val);
>
> Maybe setting port type should be a separate function from init_phy?
Sure, will change in v4.
Thanks,
Andrey Smirnov
