Re: [PATCH v5 06/11] PCI: Expose reset type to users of pci_reset_bus()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/11/2018 11:33 AM, Alex Williamson wrote:
Having three cases here still seems strange.  The below still has some
duplicate probing but doesn't it do the same thing with less redundancy?

if ((reset_type & PCI_RESET_SLOT) && !pci_probe_reset_slot(pdev->slot))
	return __pci_reset_slot(pdev->slot);

if ((reset_type & PCI_RESET_BUS) && !pci_probe_reset_bus(pdev->slot))
	return __pci_reset_bus(pdev->bus);

I agree this looks cleaner. I'll fold it in on the next rev.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux