Lubomir Rintel <lkundrak@xxxxx> writes: > That seems to be the correct type. Okay, but what happens here when adev_id->driver_data is a value out of enum range ? Does the following assignment make sense ? > + type = (enum pxa_ssp_type)adev_id->driver_data; As a side note, could you join for the next throw to the review : - Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx> - Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> Even if they are Intel, I think they have worked a lot on this driver for Intel platforms. Cheers. -- Robert
