Re: [PATCH 11/12] PCI/AER: Use managed resource allocations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/19/2018 1:25 PM, Keith Busch wrote:
On Wed, Sep 19, 2018 at 12:29:15PM -0400, Sinan Kaya wrote:
On 9/18/2018 7:58 PM, Keith Busch wrote:
   	if (status) {
   		dev_printk(KERN_DEBUG, device, "request AER IRQ %d failed\n",
   			   dev->irq);
-		aer_remove(dev);
   		return status;
   	}

Don't we still need to call aer_remove() here?

Old code would call aer_disable_rootport(rpc) via aer_remove() on IRQ allocation
failure. We are no longer doing this.

We need to call aer_disable_rootport only if aer_enable_rootport was
called, but that happens *after* irq allocation.


I see. Thanks for clarification.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux