On Wed, Sep 19, 2018 at 12:29:15PM -0400, Sinan Kaya wrote: > On 9/18/2018 7:58 PM, Keith Busch wrote: > > if (status) { > > dev_printk(KERN_DEBUG, device, "request AER IRQ %d failed\n", > > dev->irq); > > - aer_remove(dev); > > return status; > > } > > Don't we still need to call aer_remove() here? > > Old code would call aer_disable_rootport(rpc) via aer_remove() on IRQ allocation > failure. We are no longer doing this. We need to call aer_disable_rootport only if aer_enable_rootport was called, but that happens *after* irq allocation.