On 9/10/2018 5:52 AM, Pasi Kärkkäinen wrote:
Hi,
On Sun, Sep 09, 2018 at 10:33:02PM -0400, Sinan Kaya wrote:
On 9/9/2018 2:59 PM, Pasi Kärkkäinen wrote:
I noticed pcie_has_flr() has been recently exported in upstream Linux:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2d2917f7747805a1f4188672f308d82a8ba01700
Are there more changes / cleanups planned to these interfaces, as mentioned last year?
(context: xen-pciback reset/do_flr features upstreaming, which kind of stalled last year when pcie_has_flr() wasn't exported at the time)
Exporting pcie_has_flr() is a very simple change which could have been done
by the XEN porting effort.
Maybe, the right question is what is so special about XEN reset?
What feature PCI core is missing to support XEN FLR reset that caused
the effort to stall?
Well one of the reasons probably was because Christoph was planning to deprecate the pcie_has_flr() functionality..
https://lists.xen.org/archives/html/xen-devel/2017-12/msg01057.html
https://lists.xen.org/archives/html/xen-devel/2017-12/msg01252.html
But now that pcie_has_flr() is exported and available I guess it's fine to continue using it also for xen-pciback :)
Yeah, I would go ahead with the implementation. Refactoring can be done
independently.
Thanks,
-- Pasi
