Hi, Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> writes: > Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> writes: >>> Since this applies to all resets, I think you also need to get rid of >>>> waits following different reset types in step #2 and return immediately. >>>> I suggest you review callers of pci_dev_wait() and tap in there. >>> >>> I agree; I think we should be able to skip the delays in pcie_flr(), >>> pci_af_flr(), etc. >> >> but that's why I put the code in pci_dev_wait(). Both pcie_flr() and >> pci_af_flr() call pci_dev_wait(); or are you saying that the msleep(100) >> call in pci_af_flr() can also be removed if (dev->imm_ready)? > > What about moving that msleep() to pci_dev_wait() itself? this will incur and extra 100ms delay on D3->D0 transitions and bus reset. Is that acceptable or would you prefer to add another check on pcie_flr() and pci_af_flr()? - balbi
Attachment:
signature.asc
Description: PGP signature
