On 8/20/2018 5:09 AM, Lukas Wunner wrote:
On Sun, Aug 19, 2018 at 05:59:33PM -0400, Sinan Kaya wrote:
On 8/19/2018 10:29 AM, Lukas Wunner wrote:
Simplify the driver by merging struct slot into struct controller.
Merge the slot constructor pcie_init_slot() and the destructor
pcie_cleanup_slot() into the controller counterparts. Rename the slot
struct's "lock" member to "state_lock" and rename "work" to "button_work"
for clarity.
please split this into multiple pieces.
Hm, you mean split out the renaming of the "lock" and "work" members?
The unification of the two structs needs to happen in a single commit
to avoid breaking the build for people doing a git bisect.
I was thinking of the rename.
Thanks,
Lukas
