On Mon, Aug 20, 2018 at 12:59:05PM -0400, Sinan Kaya wrote: > On 8/20/2018 5:22 AM, Lukas Wunner wrote: > > > + > > This differs from v7 of the patch in that*any* fatal error, not just > > a Surprise Link Down, results in pciehp waiting for the error to clear. > > > > I'm wondering if that's safe: Theoretically, the user might quickly > > swap the card in the slot during, say, a Completion Timeout Error, > > and with this patch pciehp would carry on as if nothing happened. > > Functionally both patches are identical. The v7 was still allowing > AER/DPC to handle all fatal error events except Surprise Link Down. > > Now, second patch (v8 2/2) is masking the surprise link down event > as we have talked before. Therefore, there is no need to filter > out incoming errors by reading the status register and masking the > unwanted bits. Ok, missed that. > Just to clarify something, this patch will wait for only the FATAL > error events to be handled by the error handling services only. > > Completion Timeout is a NONFATAL error event by default unless > somebody tweaks the severity bits. > > Anyhow, all FATAL errors cause one sort of link down either > initiated by software (AER) or hardware (DPC). > Therefore, hotplug driver will observe a link down event and > AER/DPC needs to handle the event as usual. Thanks for the clarification. Lukas
