On 8/16/18 5:09 PM, Benjamin Herrenschmidt wrote: > On Thu, 2018-08-16 at 15:56 -0600, Jens Axboe wrote: >> On 8/16/18 3:37 PM, Benjamin Herrenschmidt wrote: >>> On Thu, 2018-08-16 at 13:43 -0600, Jens Axboe wrote: >>>> >>>>> Ok. Well, my patch fixes it for my repro-case at least and seems to not >>>>> break anyhting on my thinkpad so ... >>>>> >>>>> Bjorn, are you ok with the approach ? If yes, I'll start breaking up >>>>> that patch into a few smaller bits in case something goes wrong and we >>>>> want to bisect (such as the changes I did to tracking is_busmaster >>>>> etc...) >>>> >>>> I can try it too, but I was never CC'ed on the actual patch. >>> >>> https://lore.kernel.org/lkml/08bc40a6af3e614e97a78fbaab688bfcd14520ac.camel@xxxxxxxxxxxxxxxxxxx/ >>> >>> (I'll also fwd privately) >> >> Boots and works fine for me, but I'm also now on a gen6 x1, my initial >> report was on a gen4. I still have the gen4, I can power it up and see >> if it works there as well. > > Mine is a gen4 and it works fine :) OK good, saves me the time then :-) -- Jens Axboe