On 2018-08-06 20:36, Sinan Kaya wrote:
On 8/6/2018 11:04 AM, Sinan Kaya wrote:
Either AER or DPC would get triggered, not both.
in that case, if AER is disabled, then this code will return false
thinking HP needs to handle it.
but it might be that DPC would be triggering as well.
but I dont see DPC check anywhere, rather we are relying on
PCI_EXP_DEVSTA
and following condition:
if (!pdev->aer_cap)
return false;
so here we dont check anything with respect to DPC capability
(although there is no such thing as dpc_cap)
(except If I missed something)
That's true. We either need to go poll every single source (AER/DPC)
for
an error or rely on the DEVSTA. For ease of implementation, I suggest
DEVSTA. Something like this:
Hmm. Too quick...
Reduced set doesn't help. Surprise Link Down is also a fatal error.
That's what I was trying to exclude. We'll have to poll the error
source.
How about using pcie_port_find_service() ?
Regards,
Oza.
