Re: Should a PCIe Link Down event set the PCI_DEV_DISCONNECTED bit?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/27/2018 11:23 AM, Alex_Gagniuc@xxxxxxxxxxxx wrote:
Completion timeouts are typically in the orders of 50ms. If you have a
lot of outstanding non-posted requests, it will take time for SW to
flush all requests.
That's why we check pci_dev_is_disconnected() in pci/access.c
But if the DISCONNECTED bit doesn't get set, it makes me wonder how
solid things currently are.

I don't see any problem by setting this bit as long as the link is
down regardless of the drive presence state and clearing it on link recovery.

Is there a problem with this approach? I'm catching up with this
thread.

pcie_do_fatal_recovery() doesn't query presence as an example.



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux