On Fri, Jul 13, 2018 at 02:38:19PM -0700, Stephen Hemminger wrote:
> PS: it is nuisance that when the PCI support was moved to
> drivers/pci/controllers it was not done in a way that git correctly
> tracked the rename. Therefore all the commit history was broken :-(
Oooh, that's my fault, and I'm really sorry about that. For future
reference, what *should* I have done?
Both the original patch [1] and 6e0832fa432e ("PCI: Collect all native
drivers under drivers/pci/controller/") *look* like they comprehend
renames, e.g.,
diff --git a/drivers/pci/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
similarity index 100%
rename from drivers/pci/dwc/pci-exynos.c
rename to drivers/pci/controller/dwc/pci-exynos.c
IIRC I just applied that patch from email with "stg import", but maybe
I should have used "git mv" instead? I did try "git mv" just now, and
"git log" doesn't show history before the rename, while
"git log --follow" does.
Anyway, sorry about breaking history; I really hate that.
Bjorn
[1] https://lkml.kernel.org/r/1527729157-201428-1-git-send-email-shawn.lin@xxxxxxxxxxxxxx
