On 7/19/2018 8:55 AM, Alex G. wrote:
I find the intent clearer if we check it here rather than having to do the mental parsing of the state of aer_cap.
I don't feel too strong about my comment to be honest. This was a style/maintenance comment. It feels like we are putting pcie_aer_get_firmware_first() into core functions unnecessarily after your change. I understand the need for your change. I'm asking if it is the right place or not. pcie_aer_get_firmware_first() should be called from either the init or probe function so that the rest of the AER functions do not get called from any other context. If someone adds another AER function, we might need to add another pcie_aer_get_firmware_first() check there. So, we have unnecessary code duplication.
