On Mon, May 14, 2018 at 4:11 AM, songxiaowei <songxiaowei@xxxxxxxxxxxxx> wrote:
>> > + int ret;
>> > +
>> > + if (IS_ENABLED(CONFIG_PCI_MSI)) {
>>
>> > + pci->pp.msi_irq = platform_get_irq(pdev, 0);
>> > + if (pci->pp.msi_irq < 0) {
>> > + dev_err(&pdev->dev, "failed to get MSI IRQ
>> (%d)\n",
>> > + pci->pp.msi_irq);
>>
>> > + return -ENODEV;
>>
>> Why shadowing actual error code?
> [songxiaowei] Sorry, I can't get your point about this, would you explain it for me.
platform_get_irq() returns either correct IRQ number or negative error code.
In the code above you shadow the actual error (as returned by that
call) by -ENODEV. Any reason why?
--
With Best Regards,
Andy Shevchenko
