Hi, Andy Shevchenko Yao is on maternity leave, and I'll take over the job after discussing with her. > -----邮件原件----- > 发件人: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx] > 发送时间: 2018年5月14日 7:16 > 收件人: chenyao (F) <chenyao11@xxxxxxxxxx> > 抄送: songxiaowei <songxiaowei@xxxxxxxxxxxxx>; Wangbinghui > <wangbinghui@xxxxxxxxxxxxx>; Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>; > Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; xuwei (O) <xuwei5@xxxxxxxxxx>; > Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; > Catalin Marinas <catalin.marinas@xxxxxxx>; Will Deacon > <will.deacon@xxxxxxx>; linux-pci@xxxxxxxxxxxxxxx; Linux Kernel Mailing List > <linux-kernel@xxxxxxxxxxxxxxx>; linux-arm Mailing List > <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; devicetree > <devicetree@xxxxxxxxxxxxxxx>; dimitrysh@xxxxxxxxxx; > guodong.xu@xxxxxxxxxx; Suzhuangluan <suzhuangluan@xxxxxxxxxxxxx>; Kongfei > <kongfei@xxxxxxxxxxxxx> > 主题: Re: [PATCH v3 1/2] PCI: kirin: Add MSI support > > On Fri, May 11, 2018 at 12:15 PM, Yao Chen <chenyao11@xxxxxxxxxx> wrote: > > Add support for MSI. > > > > + int ret; > > + > > + if (IS_ENABLED(CONFIG_PCI_MSI)) { > > > + pci->pp.msi_irq = platform_get_irq(pdev, 0); > > + if (pci->pp.msi_irq < 0) { > > + dev_err(&pdev->dev, "failed to get MSI IRQ > (%d)\n", > > + pci->pp.msi_irq); > > > + return -ENODEV; > > Why shadowing actual error code? [songxiaowei] Sorry, I can't get your point about this, would you explain it for me. > > > + } > > + ret = devm_request_irq(&pdev->dev, pci->pp.msi_irq, > > + kirin_pcie_msi_irq_handler, > > + IRQF_SHARED | > IRQF_NO_THREAD, > > + "kirin_pcie_msi", &pci->pp); > > + if (ret) { > > + dev_err(&pdev->dev, "failed to request MSI > IRQ %d\n", > > + pci->pp.msi_irq); > > + return ret; > > + } > > It would be easy to read and maintain if this would be a separate function. [songxiaowei] Yes, a separate function will be better, and I'll fix it. > > > + } > > > > -- > With Best Regards, > Andy Shevchenko Thanks a lot, Best Regards, Xiaowei Song
