Hi Oza, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16] [cannot apply to pci/next linus/master next-20180410] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180410-045644 config: x86_64-randconfig-s4-04101607 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: the linux-review/Oza-Pawandeep/Address-error-and-recovery-for-AER-and-DPC/20180410-045644 HEAD db413d3e52b272ef8e6f03ff125e65468abd31e6 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/pci/pcie/err.o: In function `reset_link': >> drivers/pci/pcie/err.c:197: undefined reference to `find_aer_service' vim +197 drivers/pci/pcie/err.c 181 182 static pci_ers_result_t reset_link(struct pci_dev *dev) 183 { 184 struct pci_dev *udev; 185 pci_ers_result_t status; 186 struct pcie_port_service_driver *driver = NULL; 187 188 if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) { 189 /* Reset this port for all subordinates */ 190 udev = dev; 191 } else { 192 /* Reset the upstream component (likely downstream port) */ 193 udev = dev->bus->self; 194 } 195 196 /* Use the aer driver of the component firstly */ > 197 driver = find_aer_service(udev); 198 199 if (driver && driver->reset_link) { 200 status = driver->reset_link(udev); 201 } else if (udev->has_secondary_link) { 202 status = default_reset_link(udev); 203 } else { 204 pci_printk(KERN_DEBUG, dev, 205 "no link-reset support at upstream device %s\n", 206 pci_name(udev)); 207 return PCI_ERS_RESULT_DISCONNECT; 208 } 209 210 if (status != PCI_ERS_RESULT_RECOVERED) { 211 pci_printk(KERN_DEBUG, dev, 212 "link reset at upstream device %s failed\n", 213 pci_name(udev)); 214 return PCI_ERS_RESULT_DISCONNECT; 215 } 216 217 return status; 218 } 219 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip