On Thu, Apr 5, 2018 at 1:24 PM, Scott Branden <scott.branden@xxxxxxxxxxxx> wrote: > Hi Rob, > > I don't think this will work. Ugg... > On 18-04-05 07:26 AM, Rob Herring wrote: >> >> Add COMPILE_TEST on driver config options with it. Some ARM drivers >> still have arch dependencies, so we have to keep those dependent on ARM. >> >> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> >> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> >> Cc: linux-pci@xxxxxxxxxxxxxxx >> Signed-off-by: Rob Herring <robh@xxxxxxxxxx> >> --- >> v3: Rework iProc again, adding GICv3 dependency >> >> v2: Rework iProc to not enable on arm64 except for COMPILE_TEST >> @@ -118,7 +117,8 @@ config PCIE_IPROC >> config PCIE_IPROC_PLATFORM >> tristate "Broadcom iProc PCIe platform bus driver" >> - depends on ARCH_BCM_IPROC || (ARM && COMPILE_TEST) >> + depends on (ARM && ARCH_BCM_IPROC) || COMPILE_TEST >> + depends on ARM_GIC_V3 >> depends on OF >> select PCIE_IPROC >> default ARCH_BCM_IPROC >> @@ -128,7 +128,8 @@ config PCIE_IPROC_PLATFORM >> config PCIE_IPROC_BCMA >> tristate "Broadcom iProc PCIe BCMA bus driver" >> - depends on ARM && (ARCH_BCM_IPROC || COMPILE_TEST) >> + depends on (ARM && ARCH_BCM_IPROC) || COMPILE_TEST >> + depends on ARM_GIC_V3 > > GIC v3 is not used for ARM (v7). So the driver now won't be compiled in > normal use case. > It sounds like some code inside the IPROC BCMA driver needs to be wrapped > with #ifdef ARM_GIC_V3 to fix this problem. I give up and will just drop these hunks. Rob
