On Wed, Mar 21, 2018 at 4:19 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > On Wed, Mar 21, 2018 at 02:42:44PM +0000, Lorenzo Pieralisi wrote: >> Rebased/reworked a patch series previously posted by Rob Herring[1]. >> >> v1 -> v2: >> - Rebased against v4.16-rc1 >> - Refactored/split patches >> >> [1] https://marc.info/?l=linux-pci&m=152043736711658&w=2 >> >> Original cover letter >> --------------------- >> >> This started with just moving private functions from of_pci.h to >> drivers/pci/pci.h, but I was annoyed with trying to build all the right >> configs, so I enabled COMPILE_TEST on a bunch of drivers. Then I fixed >> the fallout from doing that. I'm sending this as all one series, but >> really there is no dependency for the header refactoring patch. >> >> Needless to say, this series is *compile tested* only. This is based on >> Bjorn's for-linus branch (and the of_pci.h fix there). >> >> Rob >> >> Fengguang Wu (4): >> PCI: kirin: struct kirin_pcie_driver can be static >> PCI: faraday: struct faraday_pci_variant can be static >> PCI: rcar: Fix semicolon.cocci warnings >> PCI: v3-semi: Fix semicolon.cocci warnings > > If these titles were "Make XXX static" and "Remove unnecessary > semicolon" they would read the same as all the others, i.e., they > would start with a verb and contain a little more information. "Fix > XXX warnings" is not really very informative all by itself. Not sure who you are directing the comment to, but they are generated patches. Fixing what generates them would be more useful than maintainers fixing up the commit messages. Of course, following the varied whims of different maintainers is probably not scriptable. Rob
