Re: [PATCH v2 02/10] PCI: iproc: Remove dependency on ARM specific struct pci_sys_data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 21, 2018 at 4:16 PM, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> On Wed, Mar 21, 2018 at 02:42:46PM +0000, Lorenzo Pieralisi wrote:
>> From: Rob Herring <robh@xxxxxxxxxx>
>>
>> The iproc driver is using ARM's struct pci_sys_data simply to store a
>> private data pointer. This is completely unnecessary, so store the
>> private data directly in bus->sysdata as is done on arm64.
>
> Oh, thank you, this is awesome!
>
> struct pci_sys_data is still referenced in mvebu and rcar.  I didn't
> look closely enough to see if they could be similarly simplified.

I did.

> I guess not, because they use pci_common_init_dev().  They look
> tantalizingly close to being able to use pci_scan_root_bus_bridge()
> like everybody else, though.

Yes, that is the problem. It shouldn't be hard, just needs someone
with h/w to test.

Rob



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux