On Tue, 2018-03-20 at 17:47 +0100, Thomas Gleixner wrote: > On Tue, 20 Mar 2018, Andy Shevchenko wrote: > > On Tue, 2018-03-20 at 16:32 +0100, Jean Delvare wrote: > > > When fixing a regression, a good practice is to tag the fix commit > > > as > > > such: > > > > > > Fixes: 69c42d493db4 ("x86/pci: Simplify code by using the new > > > dmi_get_bios_year() helper") > > > > Someone (perhaps Ingo) told me that Fixes doesn't make much sense if > > the > > fixing commit is not yet in vanilla. > > No. If the commit is already queued for the next merge window then a > fixes > tag is appropriate. Thank you, Thomas, for clarification. Will do this in v4. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy